Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/1336: on s3 and azure add delimiter in iterate_type when prefix is empty to avoid KeyType::LOG_COMPACTED when KeyType::LOG is queried #1511

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

muhammadhamzasajjad
Copy link
Collaborator

Reference Issues/PRs

Fixes #1336

What does this implement or fix?

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@muhammadhamzasajjad muhammadhamzasajjad self-assigned this Apr 19, 2024
@muhammadhamzasajjad muhammadhamzasajjad changed the title bugfix/1336: on s3 and azure add delimiter in iterate_type when prefix is empty, to avoid KeyType::LOG_COMPACTED when KeyType::LOG is queried bugfix/1336: on s3 and azure add delimiter in iterate_type when prefix is empty to avoid KeyType::LOG_COMPACTED when KeyType::LOG is queried Apr 19, 2024
@muhammadhamzasajjad muhammadhamzasajjad marked this pull request as ready for review April 19, 2024 11:06
@muhammadhamzasajjad muhammadhamzasajjad merged commit 4d6f2ee into master Apr 19, 2024
111 checks passed
@muhammadhamzasajjad muhammadhamzasajjad deleted the bug/s3_azure_key_iterate_delimiter_bug branch April 19, 2024 16:08
grusev pushed a commit that referenced this pull request Nov 25, 2024
…x is empty to avoid KeyType::LOG_COMPACTED when KeyType::LOG is queried (#1511)

#### Reference Issues/PRs
Fixes #1336 
<!--Example: Fixes #1234. See also #3456.-->

#### What does this implement or fix?

#### Any other comments?

#### Checklist

<details>
  <summary>
   Checklist for code changes...
  </summary>
 
- [ ] Have you updated the relevant docstrings, documentation and
copyright notice?
- [ ] Is this contribution tested against [all ArcticDB's
features](../docs/mkdocs/docs/technical/contributing.md)?
- [ ] Do all exceptions introduced raise appropriate [error
messages](https://docs.arcticdb.io/error_messages/)?
 - [ ] Are API changes highlighted in the PR description?
- [ ] Is the PR labelled as enhancement or bug so it appears in
autogenerated release notes?
</details>

<!--
Thanks for contributing a Pull Request to ArcticDB! Please ensure you
have taken a look at:
- ArcticDB's Code of Conduct:
https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md
- ArcticDB's Contribution Licensing:
https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyType::LOG and KeyType::LOG_COMPACTED share the same prefix in S3 and Azure
3 participants